zeroshade commented on code in PR #460:
URL: https://github.com/apache/iceberg-go/pull/460#discussion_r2155390125
##########
table/metadata.go:
##########
@@ -877,8 +881,8 @@ func (c *commonMetadata) Equals(other *commonMetadata) bool
{
}
return c.FormatVersion == other.FormatVersion && c.UUID == other.UUID &&
- ((c.LastPartitionID == other.LastPartitionID) ||
(*c.LastPartitionID == *other.LastPartitionID)) &&
- ((c.CurrentSnapshotID == other.CurrentSnapshotID) ||
(*c.CurrentSnapshotID == *other.CurrentSnapshotID)) &&
+ equalPtr(c.LastPartitionID, other.LastPartitionID) &&
+ equalPtr(c.CurrentSnapshotID, other.CurrentSnapshotID) &&
Review Comment:
should we leave this as it was instead since there's no possibility of the
nil dereference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
