jbonofre commented on code in PR #13111: URL: https://github.com/apache/iceberg/pull/13111#discussion_r2152171035
########## gcp-bundle/LICENSE: ########## @@ -319,17 +540,65 @@ License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt -------------------------------------------------------------------------------- +Group: com.google.cloud Name: google-cloud-bigquery Version: 2.50.0 +Project URL: https://github.com/googleapis/java-bigquery +License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt + +-------------------------------------------------------------------------------- + +Group: com.google.cloud Name: google-cloud-bigquerystorage Version: 3.14.0 +Project URL: https://github.com/googleapis/java-bigquerystorage +License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt + +-------------------------------------------------------------------------------- + +Group: com.google.cloud Name: google-cloud-monitoring Version: 3.63.0 +Project URL: https://github.com/googleapis/google-cloud-java +License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt + +-------------------------------------------------------------------------------- + +Group: com.google.cloud.opentelemetry Name: detector-resources-support Version: 0.33.0 +Project URL: https://github.com/GoogleCloudPlatform/opentelemetry-operations-java +License: The Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + +-------------------------------------------------------------------------------- + +Group: com.google.cloud.opentelemetry Name: exporter-metrics Version: 0.33.0 +Project URL: https://github.com/GoogleCloudPlatform/opentelemetry-operations-java +License: The Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + +-------------------------------------------------------------------------------- + +Group: com.google.cloud.opentelemetry Name: shared-resourcemapping Version: 0.33.0 +Project URL: https://github.com/GoogleCloudPlatform/opentelemetry-operations-java +License: The Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + +-------------------------------------------------------------------------------- + Group: com.google.code.gson Name: gson Version: 2.12.1 Project URL: https://github.com/google/gson/gson Review Comment: nit: the project URL is not correct here, it should be https://github.com/google/gson ########## gcp-bundle/LICENSE: ########## @@ -227,20 +244,98 @@ License: BSD-3-Clause - https://github.com/googleapis/api-common-java/blob/main/ -------------------------------------------------------------------------------- Group: com.google.api Name: gax Version: 2.63.1 -License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt -License: BSD-3-Clause - https://github.com/googleapis/gax-java/blob/master/LICENSE +License: BSD-3-Clause Review Comment: Nit: good idea to include the project URL (https://github.com/googleapis/sdk-platform-java/tree/main/gax-java). ########## gcp-bundle/LICENSE: ########## @@ -227,20 +244,98 @@ License: BSD-3-Clause - https://github.com/googleapis/api-common-java/blob/main/ -------------------------------------------------------------------------------- Group: com.google.api Name: gax Version: 2.63.1 -License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt -License: BSD-3-Clause - https://github.com/googleapis/gax-java/blob/master/LICENSE +License: BSD-3-Clause +Copyright 2016, Google Inc. All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are +met: + + * Redistributions of source code must retain the above copyright +notice, this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above +copyright notice, this list of conditions and the following disclaimer +in the documentation and/or other materials provided with the +distribution. + * Neither the name of Google Inc. nor the names of its +contributors may be used to endorse or promote products derived from +this software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -------------------------------------------------------------------------------- Group: com.google.api Name: gax-grpc Version: 2.63.1 Review Comment: Nit: Same here about project URL (https://github.com/googleapis/sdk-platform-java). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
