fuatbasik commented on code in PR #13335:
URL: https://github.com/apache/iceberg/pull/13335#discussion_r2152170265
##########
aws/src/main/java/org/apache/iceberg/aws/s3/AnalyticsAcceleratorUtil.java:
##########
@@ -59,14 +61,21 @@ private AnalyticsAcceleratorUtil() {}
public static SeekableInputStream newStream(S3InputFile inputFile) {
S3URI uri = S3URI.of(inputFile.uri().bucket(), inputFile.uri().key());
HeadObjectResponse metadata = inputFile.getObjectMetadata();
- OpenStreamInformation openStreamInfo =
- OpenStreamInformation.builder()
- .objectMetadata(
- ObjectMetadata.builder()
- .contentLength(metadata.contentLength())
- .etag(metadata.eTag())
- .build())
- .build();
+ OpenStreamInformation.OpenStreamInformationBuilder
openStreamInformationBuilder =
+ OpenStreamInformation.builder();
+ openStreamInformationBuilder.objectMetadata(
+ ObjectMetadata.builder()
+ .contentLength(metadata.contentLength())
+ .etag(metadata.eTag())
+ .build());
+ if
(inputFile.s3FileIOProperties().sseType().equals(S3FileIOProperties.SSE_TYPE_CUSTOM))
{
Review Comment:
Hi @rajdchak . Thanks a lot for this change. How are we going to test this
change. We probably need at least some unit tests and some integration-tests if
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
