elca-anh commented on code in PR #2066:
URL: https://github.com/apache/iceberg-python/pull/2066#discussion_r2152083284


##########
mkdocs/docs/configuration.md:
##########
@@ -346,6 +346,7 @@ catalog:
 | rest.signing-name   | execute-api                      | The service signing 
name to use when SigV4 signing a request                                       |
 | oauth2-server-uri   | <https://auth-service/cc>          | Authentication 
URL to use for client credentials authentication (default: uri + 
'v1/oauth/tokens') |
 | snapshot-loading-mode | refs                             | The snapshots to 
return in the body of the metadata. Setting the value to `all` would return the 
full set of snapshots currently valid for the table. Setting the value to 
`refs` would load all snapshots referenced by branches or tags. |
+| warehouse          | myCatalog                         | For some catalog 
implementations like Databricks Unity, the warehouse is mandatory to identify 
which top level container (e.g. catalog, metastore...) is accessed. Namespaces 
are within this container. |

Review Comment:
   Warehouse is only one of the terms used by providers to identify the top 
level containers. Some are using catalog, other metastore. As it is quite 
important I suggest to be more explicit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to