amogh-jahagirdar commented on code in PR #13191: URL: https://github.com/apache/iceberg/pull/13191#discussion_r2151085076
########## core/src/main/java/org/apache/iceberg/rest/ParserContext.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest; + +import com.fasterxml.jackson.databind.InjectableValues; +import java.util.Collections; +import java.util.Map; +import org.apache.hadoop.util.Preconditions; + +class ParserContext { + + private final Map<String, Object> data; + + private ParserContext(Builder builder) { + this.data = Collections.unmodifiableMap(builder.data); + } + + public boolean isEmpty() { + return data.isEmpty(); + } + + public InjectableValues toInjectableValues() { + return new InjectableValues.Std(data); + } + + static Builder builder() { + return new Builder(); + } + + static class Builder { + private Map<String, Object> data; + + private Builder() { + this.data = Collections.emptyMap(); + } + + public Builder add(String key, Object value) { Review Comment: We should probably also not allow null values? ########## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ########## @@ -94,6 +96,7 @@ public class HTTPClient extends BaseHTTPClient { private final ObjectMapper mapper; private final AuthSession authSession; private final boolean isRootClient; + private final ConcurrentMap<Class<?>, ObjectReader> objectReaderCache = Maps.newConcurrentMap(); Review Comment: Minor: Until initializing the object reader(s) is known to be a bottleneck, I think I'd prefer to not introduce this cache. I haven't gone so deep into the jackson implementation but I'd be kind of surprised if it wasn't already doing this under the hood -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
