rambleraptor opened a new pull request, #2098:
URL: https://github.com/apache/iceberg-python/pull/2098

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace 
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   Closes #1547 
   
   # Rationale for this change
   Iceberg v3 does not support `source-id` and only supports `source-ids`. 
Meanwhile, Iceberg v2 only supports `source-id`.
   Right now, it appears that all versions of Iceberg support both `source-id` 
and `source-ids`.
   
   This PR does what #1547 asks and deprecates `source-id`. It seems like the 
most proper thing to do would be to make these fields aware of the Iceberg 
format version and then error out accordingly. But, I wanted to get everyone's 
opinion before I go down that path.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to