CTTY commented on code in PR #1433:
URL: https://github.com/apache/iceberg-rust/pull/1433#discussion_r2148863363
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -104,32 +110,13 @@ impl Transaction {
}
/// Sets table to a new version.
- pub fn upgrade_table_version(mut self, format_version: FormatVersion) ->
Result<Self> {
- let current_version = self.current_table.metadata().format_version();
- match current_version.cmp(&format_version) {
- Ordering::Greater => {
- return Err(Error::new(
- ErrorKind::DataInvalid,
- format!(
- "Cannot downgrade table version from {} to {}",
- current_version, format_version
- ),
- ));
- }
- Ordering::Less => {
- self.apply(vec![UpgradeFormatVersion { format_version }],
vec![])?;
- }
- Ordering::Equal => {
- // Do nothing.
- }
- }
- Ok(self)
+ pub fn upgrade_table_version(&self) -> UpgradeFormatVersionAction {
+ UpgradeFormatVersionAction::new()
}
/// Update table's property.
- pub fn set_properties(mut self, props: HashMap<String, String>) ->
Result<Self> {
Review Comment:
The release interval certainly is an
[issue](https://github.com/apache/iceberg-rust/issues/1327) 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
