kevinjqliu commented on code in PR #1426: URL: https://github.com/apache/iceberg-rust/pull/1426#discussion_r2147386482
########## website/src/release.md: ########## @@ -202,6 +202,35 @@ please cancel the release for the current `release_version`, _increase th RC counting_ and re-initiate a release with the new `release_version`. And remember to delete the wrong artifacts from the SVN dist repo. +## How to verify a release Review Comment: nit: move this after the "Voting" section below, which sends out the email to vote for RC ########## website/src/release.md: ########## @@ -202,6 +202,35 @@ please cancel the release for the current `release_version`, _increase th RC counting_ and re-initiate a release with the new `release_version`. And remember to delete the wrong artifacts from the SVN dist repo. +## How to verify a release Review Comment: lets add a link to this new section to the RC vote email too. the current instruction in the email is outdated https://github.com/apache/iceberg-rust/blob/bcd1033ba5c67982b7359a6330defeade9f82526/website/src/release.md#L262-L264 maybe we can remove `scripts/verify.py` too ########## Cargo.lock: ########## Review Comment: nit: is this related to the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
