CTTY commented on code in PR #1441:
URL: https://github.com/apache/iceberg-rust/pull/1441#discussion_r2146439072
##########
crates/iceberg/src/transaction/sort_order.rs:
##########
@@ -15,32 +15,97 @@
// specific language governing permissions and limitations
// under the License.
+use std::sync::Arc;
+
+use async_trait::async_trait;
+
use crate::error::Result;
use crate::spec::{NullOrder, SortDirection, SortField, SortOrder, Transform};
-use crate::transaction::Transaction;
+use crate::table::Table;
+use crate::transaction::{ActionCommit, TransactionAction};
use crate::{Error, ErrorKind, TableRequirement, TableUpdate};
+#[derive(Debug, PartialEq, Eq, Clone)]
+struct PendingSortField {
+ name: String,
+ direction: SortDirection,
+ null_order: NullOrder,
+}
+
Review Comment:
`PendingSortField` is added to defer the construction of `Vec<SortField>`
from `asc`/`desc` to `commit` to avoid passing `Table` to methods like `asc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
