amogh-jahagirdar commented on code in PR #13276:
URL: https://github.com/apache/iceberg/pull/13276#discussion_r2146082365


##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -434,9 +434,9 @@ private Map<String, PrefixedS3Client> clientByPrefix() {
     if (null == clientByPrefix) {
       synchronized (this) {
         if (null == clientByPrefix) {
-          this.clientByPrefix = Maps.newHashMap();

Review Comment:
   I'm not sure I follow the issue on how there can be visibility issues since 
the field is `volatile` and is assigned in a `synchronized` block? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to