koenvo commented on PR #1995:
URL: https://github.com/apache/iceberg-python/pull/1995#issuecomment-2970424434

   > @koenvo Looks like there are some issues with the `list` vs `large_list`, 
do you have time to dig into the issue? In the original implementation we had 
cast operations to ensure that we keep the original types.
   
   I was kind of scared by the 
   ```python
           if property_as_bool(self._io.properties, 
PYARROW_USE_LARGE_TYPES_ON_READ, False):
               deprecation_message(
                   deprecated_in="0.10.0",
                   removed_in="0.11.0",
                   help_message=f"Property `{PYARROW_USE_LARGE_TYPES_ON_READ}` 
will be removed.",
               )
               result = result.cast(arrow_schema)
   ```
   
   Currently, I do the cast in my own application code, as I ran into the same 
issue but I though it was just my implementation. Had to add the cast.
   
   And happy to give into this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to