CTTY commented on code in PR #1433: URL: https://github.com/apache/iceberg-rust/pull/1433#discussion_r2143455195
########## crates/iceberg/src/transaction/upgrade_format_version.rs: ########## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::any::Any; +use std::cmp::Ordering; +use std::sync::Arc; + +use async_trait::async_trait; + +use crate::TableUpdate::UpgradeFormatVersion; +use crate::spec::FormatVersion; +use crate::table::Table; +use crate::transaction::action::{ActionCommit, TransactionAction}; +use crate::{Error, ErrorKind, Result, TableUpdate}; + +/// A transaction action to upgrade a table's format version. +/// +/// This action is used within a transaction to indicate that the +/// table's format version should be upgraded to a specified version. +/// The location remains optional until explicitly set via [`set_format_version`]. +pub struct UpgradeFormatVersionAction { Review Comment: No worries! I tried merging this logic with `update_properties` but I still prefer keeping an independent `UpgradeFormatVersionAction`: merging this to `UpdatePropAction` will make `UpdatePropAction::commit` noisier, as it has to check if `updates` contains this property, convert it to `FormatVersion`, and finally append a `TableUpdate` if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
