liurenjie1024 commented on issue #1388: URL: https://github.com/apache/iceberg-rust/issues/1388#issuecomment-2966035105
> Other implementations use a metastore catalog that encapsulates some of this shared logic. For example, there is pyiceberg's [`MetastoreCatalog._write_metadata`](https://github.com/apache/iceberg-python/blob/4b96d2f49b04ff7ec551646f489ecc50ac195b5d/pyiceberg/catalog/__init__.py#L775) or Java's [`BaseMetastoreTableOperations.writeNewMetadata`](https://github.com/apache/iceberg/blob/d1027fc6456b7a98f6e421f259a4018b71796c05/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L154). > > I'd be happy to take a look at this. I've already drafted a version of it while working on [`MemoryCatalog::update_table`](https://github.com/apache/iceberg-rust/pull/1290), but would like to move it a shared place instead. > > Whether or not we would want to add something like a `MetastoreCatalog` trait with default implementations is a different discussion, but I think such a change would build a good foundation for it. I don't think we need another trait. Maybe we just need a `TableMetadataWriter` which could be created from `Table` would be enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
