c-thiel commented on code in PR #1362:
URL: https://github.com/apache/iceberg-rust/pull/1362#discussion_r2140988029


##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -654,6 +670,33 @@ impl TableMetadata {
     }
 }
 
+/// Unnormalized table metadata, used as an intermediate type
+/// to build table metadata in a declarative way.
+#[derive(Debug, PartialEq, Deserialize, Eq, Clone)]
+pub struct UnnormalizedTableMetadata(TableMetadata);

Review Comment:
   Mainly due to my point 1) in this comment: 
https://github.com/apache/iceberg-rust/pull/1362#discussion_r2140970629
   
   I don't think there should be any constructor that allows to create 
unvalidated / potentially corrupt `TableMetadata`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to