ZENOTME commented on issue #1355: URL: https://github.com/apache/iceberg-rust/issues/1355#issuecomment-2963262128
I find that we already have rewrite_not for partition filter: https://github.com/apache/iceberg-rust/blob/b84e0d28697896309ec4131c40e8d192ff00bfd4/crates/iceberg/src/scan/cache.rs#L85 Maybe we can transfer this invariant to `ManifestEvaluator::New` to make it clearer. One problem I find is that although we have rewrite_not logic, it can't process nested not like `not(not(not(bar > 10)))`. And I fixed it in #1431. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
