geruh opened a new pull request, #2083:
URL: https://github.com/apache/iceberg-python/pull/2083

   # Rationale for this change
   
   This PR is adding a check for all tables in the GlueCatalog instead of just 
iceberg tables.  
   
   GlueCatalog allows users to store other table formats under the same 
database. Using the catalog's `list_tables()` call filters out non-Iceberg 
table types, which avoids the proper Iceberg `NamespaceNotEmptyError` and 
instead returns a generic Glue SDK error.
   
   This change aligns with the behavior in the java implementation:
   - 
https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java#L538-L571
   
   # Are these changes tested?
   
   Tested locally with Glue Catalog
   
   # Are there any user-facing changes?
   
   Yes new exception message when a `drop_namespace()` call is made against a 
database with non-iceberg tables.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to