slfan1989 commented on code in PR #12844:
URL: https://github.com/apache/iceberg/pull/12844#discussion_r2138972580


##########
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##########
@@ -112,5 +122,15 @@ interface Result {
 
     /** Name of latest metadata file version */
     String latestVersion();
+
+    /** count of rewrite delete files, default value is 0 */
+    default int deleteFilesCount() {
+      return 0;
+    }
+
+    /** count of rewrite metadata files involved, default value is 0 */
+    default int metadataFilesCount() {
+      return 0;

Review Comment:
   > @slfan1989 @szehon-ho I meant outputting to console if user doesn't want 
to save to file. If that's not possible when the plan is big, maybe add two 
more output values, "rewrite_delete_files_count" and 
"rewrite_metadata_files_count". Then I think `file_list` file can be optional.
   
   @dramaticlly Thank you very much for reviewing the code! These changes were 
made based on discussions with @manuzhang. 
   
   Do you have any suggestions for the default values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to