jayceslesar commented on code in PR #2071: URL: https://github.com/apache/iceberg-python/pull/2071#discussion_r2137655474
########## pyiceberg/catalog/dynamodb.py: ########## @@ -94,20 +95,29 @@ class DynamoDbCatalog(MetastoreCatalog): - def __init__(self, name: str, **properties: str): - super().__init__(name, **properties) + def __init__(self, name: str, client: Optional[DynamoDBClient] = None, **properties: str): + """Dynamodb catalog. - session = boto3.Session( - profile_name=properties.get(DYNAMODB_PROFILE_NAME), - region_name=get_first_property_value(properties, DYNAMODB_REGION, AWS_REGION), - botocore_session=properties.get(BOTOCORE_SESSION), - aws_access_key_id=get_first_property_value(properties, DYNAMODB_ACCESS_KEY_ID, AWS_ACCESS_KEY_ID), - aws_secret_access_key=get_first_property_value(properties, DYNAMODB_SECRET_ACCESS_KEY, AWS_SECRET_ACCESS_KEY), - aws_session_token=get_first_property_value(properties, DYNAMODB_SESSION_TOKEN, AWS_SESSION_TOKEN), - ) - self.dynamodb = session.client(DYNAMODB_CLIENT) - self.dynamodb_table_name = self.properties.get(DYNAMODB_TABLE_NAME, DYNAMODB_TABLE_NAME_DEFAULT) - self._ensure_catalog_table_exists_or_create() + Args: + name: Name to identify the catalog. + client: An optional boto3 dynamodb client. + properties: Properties for dynamodb client construction and configuration. + """ + super().__init__(name, **properties) + if client is not None: + self.dynamodb = client + else: + session = boto3.Session( + profile_name=properties.get(DYNAMODB_PROFILE_NAME), + region_name=get_first_property_value(properties, DYNAMODB_REGION, AWS_REGION), + botocore_session=properties.get(BOTOCORE_SESSION), + aws_access_key_id=get_first_property_value(properties, DYNAMODB_ACCESS_KEY_ID, AWS_ACCESS_KEY_ID), + aws_secret_access_key=get_first_property_value(properties, DYNAMODB_SECRET_ACCESS_KEY, AWS_SECRET_ACCESS_KEY), + aws_session_token=get_first_property_value(properties, DYNAMODB_SESSION_TOKEN, AWS_SESSION_TOKEN), + ) + self.dynamodb = session.client(DYNAMODB_CLIENT) + self.dynamodb_table_name = self.properties.get(DYNAMODB_TABLE_NAME, DYNAMODB_TABLE_NAME_DEFAULT) Review Comment: After a second look I dont know if we need to make a change `_ensure_catalog_table_exists_or_create` makes the dynamo table which is needed to make iceberg tables ########## pyiceberg/catalog/dynamodb.py: ########## @@ -94,20 +95,29 @@ class DynamoDbCatalog(MetastoreCatalog): - def __init__(self, name: str, **properties: str): - super().__init__(name, **properties) + def __init__(self, name: str, client: Optional[DynamoDBClient] = None, **properties: str): + """Dynamodb catalog. - session = boto3.Session( - profile_name=properties.get(DYNAMODB_PROFILE_NAME), - region_name=get_first_property_value(properties, DYNAMODB_REGION, AWS_REGION), - botocore_session=properties.get(BOTOCORE_SESSION), - aws_access_key_id=get_first_property_value(properties, DYNAMODB_ACCESS_KEY_ID, AWS_ACCESS_KEY_ID), - aws_secret_access_key=get_first_property_value(properties, DYNAMODB_SECRET_ACCESS_KEY, AWS_SECRET_ACCESS_KEY), - aws_session_token=get_first_property_value(properties, DYNAMODB_SESSION_TOKEN, AWS_SESSION_TOKEN), - ) - self.dynamodb = session.client(DYNAMODB_CLIENT) - self.dynamodb_table_name = self.properties.get(DYNAMODB_TABLE_NAME, DYNAMODB_TABLE_NAME_DEFAULT) - self._ensure_catalog_table_exists_or_create() + Args: + name: Name to identify the catalog. + client: An optional boto3 dynamodb client. + properties: Properties for dynamodb client construction and configuration. + """ + super().__init__(name, **properties) + if client is not None: + self.dynamodb = client + else: + session = boto3.Session( + profile_name=properties.get(DYNAMODB_PROFILE_NAME), + region_name=get_first_property_value(properties, DYNAMODB_REGION, AWS_REGION), + botocore_session=properties.get(BOTOCORE_SESSION), + aws_access_key_id=get_first_property_value(properties, DYNAMODB_ACCESS_KEY_ID, AWS_ACCESS_KEY_ID), + aws_secret_access_key=get_first_property_value(properties, DYNAMODB_SECRET_ACCESS_KEY, AWS_SECRET_ACCESS_KEY), + aws_session_token=get_first_property_value(properties, DYNAMODB_SESSION_TOKEN, AWS_SESSION_TOKEN), + ) + self.dynamodb = session.client(DYNAMODB_CLIENT) + self.dynamodb_table_name = self.properties.get(DYNAMODB_TABLE_NAME, DYNAMODB_TABLE_NAME_DEFAULT) Review Comment: After a second look I dont know if we need to make a change `_ensure_catalog_table_exists_or_create` makes the dynamo table which is needed to make + interact with iceberg tables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
