liziyan-lzy commented on code in PR #13264:
URL: https://github.com/apache/iceberg/pull/13264#discussion_r2137123172


##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -197,8 +221,8 @@ public void testDryRun() throws IOException, 
InterruptedException {
   }
 
   @TestTemplate
-  public void testAllValidFilesAreKept() throws IOException, 
InterruptedException {
-    Table table = TABLES.create(SCHEMA, SPEC, Maps.newHashMap(), 
tableLocation);
+  public void testAllValidFilesAreKept() throws IOException {
+    Table table = TABLES.create(SCHEMA, SPEC, properties, tableLocation);

Review Comment:
   @pvary In the previous Spark 3.4 test, the default table properties were 
overlooked. These have been modified according to the Spark 3.5 and Spark 4.0. 
Please take a look at these changes in Spark 3.4 tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to