smaheshwar-pltr commented on code in PR #13136:
URL: https://github.com/apache/iceberg/pull/13136#discussion_r2134655837
##########
core/src/main/java/org/apache/iceberg/encryption/KeyManagementClient.java:
##########
@@ -24,7 +24,7 @@
import java.util.Map;
/** A minimum client interface to connect to a key management service (KMS). */
-interface KeyManagementClient extends Serializable, Closeable {
+public interface KeyManagementClient extends Serializable, Closeable {
Review Comment:
Also, I believe that it being public allows catalogs / table operations in
other packages *use* the KMS client - e.g.
https://github.com/apache/iceberg/pull/13066 /
https://github.com/apache/iceberg/pull/13225.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
