amogh-jahagirdar commented on code in PR #13234:
URL: https://github.com/apache/iceberg/pull/13234#discussion_r2129802487
##########
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##########
@@ -461,7 +466,8 @@ private static String
addRequestTestCaseAndGetPath(HttpMethod method, Item body,
.withMethod(method.name().toUpperCase(Locale.ROOT))
.withHeader("Authorization", "Bearer " + BEARER_AUTH_TOKEN)
.withHeader(HTTPClient.CLIENT_VERSION_HEADER,
icebergBuildFullVersion)
- .withHeader(HTTPClient.CLIENT_GIT_COMMIT_SHORT_HEADER,
icebergBuildGitCommitShort);
+ .withHeader(HTTPClient.CLIENT_GIT_COMMIT_SHORT_HEADER,
icebergBuildGitCommitShort)
+ .withHeader(USER_AGENT, TEST_USER_AGENT);
Review Comment:
Just for my understanding, if I have a HTTP client configured to
"my-user-agent" and then I later set it to "some-new-agent" on the request
level, it will override it at the request level right? Just wanted to double
check the order of precedence (not that I expect it to be used in practice that
way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
