MisterRaindrop commented on issue #118:
URL: https://github.com/apache/iceberg-cpp/issues/118#issuecomment-2943082028

     I have see warning like it, It seem code run normally. however, there are 
compile on warnings. All warnings are of this kind.
   Do we need to handle this warning?  If we need to handle it, it might be 
better to throw an exception.
   like it:
   ```
   nlohmann::json ToJson(const Type& type) {
     switch (type.type_id()) {
        case xx:
              xxxx
     }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to