huaxingao commented on PR #13230:
URL: https://github.com/apache/iceberg/pull/13230#issuecomment-2942942099
@wypoon Thanks for adding the test for the DataFrame API path! Just a small
thought: it might be a bit cleaner to keep the SQL and DataFrame logic in
separate methods, rather than combining them with a conditional.
Would something like this be clearer?
```
@TestTemplate
public void testMergeWithAllClauses() {
setup();
sql("MERGE INTO ...");
verify();
}
@TestTemplate
public void testMergeWithAllClausesUsingDataFrameAPI() {
setup();
spark.table("source")
.mergeInto(...)
.merge();
verify();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
