laskoviymishka commented on code in PR #431:
URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2127183870
##########
table/update_schema.go:
##########
@@ -191,14 +189,12 @@ func (us *UpdateSchema) Apply() *iceberg.Schema {
return us.applyChanges()
}
-//
══════════════════════════════INTERNAL══════════════════════════════════════║
-
func (su *UpdateSchema) isAdded(name string) bool {
_, ok := su.addedNameToID[name]
return ok
}
-func (us *UpdateSchema) internalAddColumn(parent, name string, new_id int,
required bool, dataType iceberg.Type, doc string, initialDefaultValue any)
*UpdateSchema {
+func (us *UpdateSchema) InternalAddColumn(parent, name string, new_id int,
required bool, dataType iceberg.Type, doc string, initialDefaultValue any)
*UpdateSchema {
Review Comment:
it's just `AddColumn` now, internal nature of it is artificial, no need for
overcomplicated things :D
keep it simple,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
