mapleFU commented on code in PR #117: URL: https://github.com/apache/iceberg-cpp/pull/117#discussion_r2126930923
########## src/iceberg/datum.h: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <compare> +#include <memory> +#include <string> +#include <variant> +#include <vector> + +#include "iceberg/result.h" +#include "iceberg/type.h" + +namespace iceberg { + +/// \brief Exception type for values that are below the minimum allowed value for a +/// primitive type. +/// +/// When casting a value to a narrow primitive type, if the value exceeds the maximum of +/// dest type, it might be above the maximum allowed value for that type. +struct BelowMin { + bool operator==(const BelowMin&) const = default; + std::strong_ordering operator<=>(const BelowMin&) const = default; +}; + +/// \brief Exception type for values that are above the maximum allowed value for a +/// primitive type. +/// +/// When casting a value to a narrow primitive type, if the value exceeds the maximum of +/// dest type, it might be above the maximum allowed value for that type. +struct AboveMax { + bool operator==(const AboveMax&) const = default; + std::strong_ordering operator<=>(const AboveMax&) const = default; +}; + +using PrimitiveLiteralValue = + std::variant<bool, // for boolean + int32_t, // for int, date + int64_t, // for long, timestamp, timestamp_tz, time + float, // for float + double, // for double + std::string, // for string Review Comment: C++ string not requires utf8, so I wonder whether `std::vector<uint8_t>` with string is possible ########## src/iceberg/datum.h: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <compare> +#include <memory> +#include <string> +#include <variant> +#include <vector> + +#include "iceberg/result.h" +#include "iceberg/type.h" + +namespace iceberg { + +/// \brief Exception type for values that are below the minimum allowed value for a +/// primitive type. +/// +/// When casting a value to a narrow primitive type, if the value exceeds the maximum of +/// dest type, it might be above the maximum allowed value for that type. +struct BelowMin { + bool operator==(const BelowMin&) const = default; + std::strong_ordering operator<=>(const BelowMin&) const = default; +}; + +/// \brief Exception type for values that are above the maximum allowed value for a +/// primitive type. +/// +/// When casting a value to a narrow primitive type, if the value exceeds the maximum of +/// dest type, it might be above the maximum allowed value for that type. +struct AboveMax { + bool operator==(const AboveMax&) const = default; + std::strong_ordering operator<=>(const AboveMax&) const = default; +}; + +using PrimitiveLiteralValue = + std::variant<bool, // for boolean + int32_t, // for int, date + int64_t, // for long, timestamp, timestamp_tz, time + float, // for float + double, // for double + std::string, // for string + std::vector<uint8_t>, // for binary, fixed, decimal and uuid + BelowMin, AboveMax>; + +/// \brief PrimitiveLiteral is owned literal of a primitive type. +class PrimitiveLiteral { + public: + explicit PrimitiveLiteral(PrimitiveLiteralValue value, + std::shared_ptr<PrimitiveType> type); + + // Factory methods for primitive types + static PrimitiveLiteral Boolean(bool value); + static PrimitiveLiteral Integer(int32_t value); + static PrimitiveLiteral Long(int64_t value); + static PrimitiveLiteral Float(float value); + static PrimitiveLiteral Double(double value); + static PrimitiveLiteral String(std::string value); + static PrimitiveLiteral Binary(std::vector<uint8_t> value); + + /// Create iceberg value from bytes. + /// + /// See [this spec](https://iceberg.apache.org/spec/#binary-single-value-serialization) + /// for reference. + static Result<PrimitiveLiteral> Deserialize(std::span<const uint8_t> data); + /// Serialize iceberg value to bytes. + /// + /// See [this spec](https://iceberg.apache.org/spec/#binary-single-value-serialization) + /// for reference. + Result<std::vector<uint8_t>> Serialize() const; + + /// Get the value as a variant + const PrimitiveLiteralValue& value() const; + + /// Get the Iceberg Type of the literal + const std::shared_ptr<PrimitiveType>& type() const; + + /// Cast the literal to a specific type + Result<PrimitiveLiteral> CastTo( + const std::shared_ptr<PrimitiveType>& target_type) const; + + std::partial_ordering operator<=>(const PrimitiveLiteral& other) const; + + std::string ToString() const; + + private: + PrimitiveLiteralValue value_; + std::shared_ptr<PrimitiveType> type_; Review Comment: don't know `std::shared_ptr<PrimitiveType>` to heavy for this type ########## src/iceberg/datum.h: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <compare> +#include <memory> +#include <string> +#include <variant> +#include <vector> + +#include "iceberg/result.h" +#include "iceberg/type.h" + +namespace iceberg { + +/// \brief Exception type for values that are below the minimum allowed value for a +/// primitive type. +/// +/// When casting a value to a narrow primitive type, if the value exceeds the maximum of +/// dest type, it might be above the maximum allowed value for that type. +struct BelowMin { + bool operator==(const BelowMin&) const = default; + std::strong_ordering operator<=>(const BelowMin&) const = default; +}; + +/// \brief Exception type for values that are above the maximum allowed value for a +/// primitive type. +/// +/// When casting a value to a narrow primitive type, if the value exceeds the maximum of +/// dest type, it might be above the maximum allowed value for that type. +struct AboveMax { + bool operator==(const AboveMax&) const = default; + std::strong_ordering operator<=>(const AboveMax&) const = default; +}; + +using PrimitiveLiteralValue = + std::variant<bool, // for boolean + int32_t, // for int, date + int64_t, // for long, timestamp, timestamp_tz, time + float, // for float + double, // for double + std::string, // for string + std::vector<uint8_t>, // for binary, fixed, decimal and uuid Review Comment: uuid and decimal are fixed 16 bytes, maybe tools needs added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
