nastra commented on code in PR #13123: URL: https://github.com/apache/iceberg/pull/13123#discussion_r2125864220
########## api/src/test/java/org/apache/iceberg/TestHelpers.java: ########## @@ -54,7 +54,7 @@ public class TestHelpers { private TestHelpers() {} - public static final int MAX_FORMAT_VERSION = 3; + public static final int MAX_FORMAT_VERSION = 4; Review Comment: yes that's correct but there just won't be any v4 features available that those users could use. Are you worried that this will lead to issues? As I mentioned in an earlier comment we already did the same thing with v3. We added the v3-specific writers first before v3 spec and implementation work landed on main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org