nastra commented on code in PR #13190:
URL: https://github.com/apache/iceberg/pull/13190#discussion_r2125872215
##########
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##########
@@ -332,6 +345,48 @@ public void testMaxConnectionSettingsFromDefaults() {
.isEqualTo(HTTPClient.REST_MAX_CONNECTIONS_PER_ROUTE_DEFAULT);
}
+ @Test
+ public void testLoadTLSConfigurer() {
+ Map<String, String> properties =
+ ImmutableMap.of(HTTPClient.REST_TLS_CONFIGURER,
DefaultTLSConfigurer.class.getName());
+ HttpClientConnectionManager connectionManager =
+ HTTPClient.configureConnectionManager(properties);
+
assertThat(connectionManager).isInstanceOf(PoolingHttpClientConnectionManager.class);
+ assertThat(DefaultTLSConfigurer.count).isEqualTo(1);
+ }
+
+ @Test
+ public void testLoadTLSConfigurer_NoArgConstructorNotFound() {
Review Comment:
nit: I know we use this naming scheme with `_` in the name in
`TestCatalogUtil` but I feel like just omitting it reads better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
