wypoon commented on code in PR #13208:
URL: https://github.com/apache/iceberg/pull/13208#discussion_r2124641007
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -1326,7 +1326,7 @@ public void
testParallelPartialProgressWithMaxFailedCommits() {
}
@TestTemplate
- public void
testParallelPartialProgressWithMaxFailedCommitsLargerThanTotalFileGroup() {
+ public void
testParallelPartialProgressWithMaxCommitsLargerThanTotalFileGroup() {
Review Comment:
Since you are renaming the test, may I suggest
`testParallelPartialProgressWithMaxCommitsGreaterThanTotalGroupCount`? as the
number returned by `FileRewritePlan` is called `totalGroupCount`.
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -1341,7 +1341,8 @@ public void
testParallelPartialProgressWithMaxFailedCommitsLargerThanTotalFileGr
// Since we can have at most one commit per file group and there
are only 10 file
// groups, actual number of commits is 10
.option(RewriteDataFiles.PARTIAL_PROGRESS_MAX_COMMITS, "20")
- .option(RewriteDataFiles.PARTIAL_PROGRESS_MAX_FAILED_COMMITS, "0");
+ // Setting max-failed-commits to 1 to tolerate random commit
failure
+ .option(RewriteDataFiles.PARTIAL_PROGRESS_MAX_FAILED_COMMITS, "1");
Review Comment:
For my own edification -- so the cause of intermittent failure is random
commit failure? Any idea why that happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
