tomtongue commented on code in PR #13214:
URL: https://github.com/apache/iceberg/pull/13214#discussion_r2123669562


##########
docs/docs/flink-ddl.md:
##########
@@ -152,6 +152,18 @@ Table create commands support the commonly used [Flink 
create clauses](https://n
 * `COMMENT 'table document'` to set a table description.
 * `WITH ('key'='value', ...)` to set [table configuration](configuration.md) 
which will be stored in Iceberg table properties.
 
+To specify the table location, use `WITH ('location'='fully-qualified-uri')` 
instead of `LOCATION`:

Review Comment:
   @mxm Sorry I haven't got some parts of your comments. I believe FlinkSQL 
doesn't have the `LOCATION` clause to specify an Iceberg table location when 
creating a new Iceberg table. To do this in FlinkSQL, using `WITH 
('location'='/path/to')` is required. So this description tries to show how to 
create an Iceberg table with specifying location. So, maybe adding `LOCATION` 
SQL clause to the Flink side seems to be good along with showing this way of 
specifying table location. If I'm wrong, please correct me. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to