szehon-ho commented on code in PR #12885:
URL: https://github.com/apache/iceberg/pull/12885#discussion_r2122411984
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -373,14 +385,15 @@ private static RewriteResult<DataFile> writeDataFileEntry(
DataFiles.builder(spec).copy(entry.file()).withPath(targetDataFilePath).build();
appendEntryWithFile(entry, writer, newDataFile);
// keep deleted data file entries but exclude them from copyPlan
- if (entry.isLive()) {
+ if (entry.isLive() && deltaSnapshotIds.contains(entry.snapshotId())) {
Review Comment:
Can you add the comment above, something like?
// Keep the following entries in metadata but exclude from copy plan
// 1) deleted files
// 2) entries not changed by snapshots within the range
##########
.palantir/revapi.yml:
##########
@@ -1178,6 +1178,32 @@ acceptedBreaks:
new: "class org.apache.iceberg.Metrics"
justification: "Java serialization across versions is not guaranteed"
org.apache.iceberg:iceberg-core:
+ - code: "java.method.numberOfParametersChanged"
Review Comment:
to be safe, we should keep the old methods
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -297,6 +297,7 @@ private static List<ManifestFile>
manifestFilesInSnapshot(FileIO io, Snapshot sn
*/
public static RewriteResult<DataFile> rewriteDataManifest(
ManifestFile manifestFile,
+ Set<Long> deltaSnapshotIds,
Review Comment:
can you add to javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
