jbonofre commented on PR #11977: URL: https://github.com/apache/iceberg/pull/11977#issuecomment-2931565362
The plugin is definitely better than nothing as soon as there's a manual pass, because: 1. The plugin lists all license for a dependency (dual license), which is wrong, license should be exclusive. 2. The distribution should include pointer or inline license content for BSD/MIT, the plugin doesn't do that. 3. The dependencies should be grouped to avoid a lot of duplicate content 4. The NOTICE should be analyzed and correctly populated (it's manual) As an example, here's a LICENSE/NOTICE I did mixing script I created and manual check: * https://github.com/apache/polaris/blob/main/quarkus/distribution/LICENSE * https://github.com/apache/polaris/blob/main/quarkus/distribution/NOTICE So, if the plugin is an assistance tool, it's totally fine, but it needs manual check imho (and also if the plugin is able to group dependencies, that would be great). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
