jmelinav commented on code in PR #13130: URL: https://github.com/apache/iceberg/pull/13130#discussion_r2121966954
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ########## @@ -508,7 +508,7 @@ public void createNamespace(Namespace namespace, Map<String, String> meta) { @Override public List<Namespace> listNamespaces(Namespace namespace) { - if (!isValidateNamespace(namespace) && !namespace.isEmpty()) { + if (!namespace.isEmpty() && (!isValidateNamespace(namespace) || !namespaceExists(namespace))) { Review Comment: the issue is with non existing namespace, if I move the lines 514-516 to the beginning, it will always return empty list irrespective of whether namespace exists or not. (which is the current behavior). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org