talatuyarer commented on code in PR #13216:
URL: https://github.com/apache/iceberg/pull/13216#discussion_r2121592353
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSFileIO.java:
##########
@@ -70,7 +70,7 @@ public class GCSFileIO implements DelegateFileIO,
SupportsStorageCredentials {
private MetricsContext metrics = MetricsContext.nullMetrics();
private final AtomicBoolean isResourceClosed = new AtomicBoolean(false);
private SerializableMap<String, String> properties = null;
- private List<StorageCredential> storageCredentials = ImmutableList.of();
+ private List<StorageCredential> storageCredentials = Lists.newArrayList();
Review Comment:
nit: Could you drop a comment to offer immediate context to future
maintainers directly in the code ?
Such as
```
// Using Lists.newArrayList() for Kryo compatibility with empty lists,
// as ImmutableList.of() or List.of() can cause issues during Kryo
serialization.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
