CuteChuanChuan commented on issue #13178: URL: https://github.com/apache/iceberg/issues/13178#issuecomment-2930981639
Hi @ajantha-bhat , I'm working on fixing ErrorProne warnings and have two that I'd like guidance on: 1. DangerousParallelStreamUsage in BigQueryMetastoreClientImpl#491 [Link to code](https://github.com/apache/iceberg/blob/a4b2a0dab092821d4843749b8abc30208622e164/bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreClientImpl.java#L491) Context: I noticed that .parallel() is mostly used in test files throughout the codebase. The ParallelIterable class seems designed for processing multiple data sources rather than parallelizing operations on a single collection. Question: Should I simply remove the .parallel() call to align with the project patterns? 2. ImmutableEnumChecker in Timestamps#47 [Link to code](https://github.com/apache/iceberg/blob/a4b2a0dab092821d4843749b8abc30208622e164/api/src/main/java/org/apache/iceberg/transforms/Timestamps.java#L47) Context: The SerializableFunction field isn't annotated with @Immutable. I noticed the [Dates enum](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/transforms/Dates.java) uses a static nested class with @Immutable annotation. Question: Should I follow the same pattern as Dates - creating an @Immutable static nested class? Process Question Should these two fixes be in separate PRs, or is it fine to include both in a single "Fix ErrorProne warnings" PR? Thanks for your guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
