lishuxu commented on code in PR #111:
URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2114975759
##########
src/iceberg/table.h:
##########
@@ -44,21 +48,21 @@ class ICEBERG_EXPORT Table {
/// \brief Refresh the current table metadata
virtual Status Refresh() = 0;
- /// \brief Return the schema for this table
- virtual const std::shared_ptr<Schema>& schema() const = 0;
+ /// \brief Return the schema for this table, return NotFoundError if not
found
+ virtual Result<std::shared_ptr<Schema>> schema() const = 0;
Review Comment:
The method name schema will conflicts with the Schema object name, and since
this is actually a lazy getter, I think it can be treated as an accessor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
