stevenzwu commented on code in PR #11775:
URL: https://github.com/apache/iceberg/pull/11775#discussion_r2114406144
##########
api/src/test/java/org/apache/iceberg/expressions/TestTimestampLiteralConversions.java:
##########
@@ -107,6 +108,33 @@ public void testTimestampMicrosToDateConversion() {
assertThat(dateOrdinal).isEqualTo(-1);
}
+ @Test
+ public void testTimestampNanoWithLongLiteral() {
+ // verify round-trip between timestamp_ns and long
+ Literal<Long> timestampNano =
+
Literal.of("2017-11-16T14:31:08.000000001").to(Types.TimestampNanoType.withoutZone());
Review Comment:
nit: `.123456789` is easier to read that there are 9 digits for nano
I created a PR for this along with changes on naming. `timestampNano` and
`longLiteral` doesn't fully capture what they represent. both are `longLiteral`
and both are `timestampNano`.
https://github.com/ebyhr/iceberg/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
