devinrsmith commented on code in PR #13132:
URL: https://github.com/apache/iceberg/pull/13132#discussion_r2114273486
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -966,6 +966,22 @@ public <T extends S3ClientBuilder> void
applyCredentialConfigurations(
: awsClientProperties.credentialsProvider(accessKeyId,
secretAccessKey, sessionToken));
}
+ public <T extends S3AsyncClientBuilder> void applyCredentialConfigurations(
Review Comment:
Great suggestion. There is a shared hierarchy targeted for `S3ClientBuilder`
and `S3AsyncClientBuilder` that is part of the AWS public API,
`S3BaseClientBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
