Xuanwo commented on code in PR #1372:
URL: https://github.com/apache/iceberg-rust/pull/1372#discussion_r2113574858
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -36,7 +37,19 @@ use crate::spec::{
use crate::table::Table;
use crate::{Error, ErrorKind, Result};
+/// The CatalogLoader trait is used to load a catalog from a given name and
properties.
+#[async_trait]
+pub trait CatalogLoader: Debug + Send + Sync {
+ /// Load a catalog from the given name and properties.
+ async fn load(properties: HashMap<String, String>) -> Result<Arc<dyn
Catalog>>;
Review Comment:
Makes sense to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
