c-thiel commented on code in PR #12584:
URL: https://github.com/apache/iceberg/pull/12584#discussion_r2112110143


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3405,6 +3488,131 @@ components:
       allOf:
         - $ref: '#/components/schemas/ScanTasks'
 
+    Actor:
+      type: object
+      description: Represents an actor that performed operations in the catalog
+      required:
+        - type
+        - actor-id
+      properties:
+        type:
+          type: string
+          description: The type of actor (e.g., "user", "principal", "role")
+        actor-id:
+          type: string
+          description: The identifier of the actor
+        metadata:
+          type: object
+          description: Additional metadata about the actor that may vary 
between implementations
+          additionalProperties:
+            type: string
+      example:
+        type: "role"
+        actor-id: "1234"
+        metadata:
+          permissions: "read-write"
+          expiration: "2025-06-07T12:00:00Z"
+          name: "Admin Role"
+        assumed-by:
+          type: "user"
+          actor-id: "4567"
+          metadata:
+            name: "Peter Cold"
+            email: "pe...@example.com"
+
+    GetEventsRequest:
+      type: object
+      properties:
+        next-page-token:
+          $ref: "#/components/schemas/PageToken"
+        page-size:
+          type: integer
+          format: int32
+          description: >
+            The maximum number of events to return in a single response.
+            If not provided, the server may choose a default page size.
+        after-timestamp-ms:
+          type: integer
+          format: int64
+          description: >
+            The (server) timestamp in milliseconds to start consuming events 
from (inclusive).
+            If not provided, the first available timestamp is used.

Review Comment:
   We do have the `next-page-token` for pagination with opaque tokens. This 
filter here is meant merely as a rough parameter to limit events obtained in 
the first request.
   Do you think a more precise description is missing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to