ZENOTME commented on code in PR #1383: URL: https://github.com/apache/iceberg-rust/pull/1383#discussion_r2111914945
########## crates/iceberg/src/error.rs: ########## @@ -134,6 +134,8 @@ pub struct Error { source: Option<anyhow::Error>, backtrace: Backtrace, + + retryable: bool, Review Comment: > This is quite confusing. Whether it's retryable should be determined by consumer by ErrorKind. `temporary: bool` +1. I think the basic idea here is to let retryable or temporary property orthogonal of ErrorKind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org