simw commented on PR #2007:
URL: https://github.com/apache/iceberg-python/pull/2007#issuecomment-2910181483
Following issue #1986 , I was about to make a smaller PR without the
knowledge of the extra spark-related complications.
In case it's useful, the only extra thing I had that you haven't (yet) added
is a small unit test in tests/io/test_pyarrow_visitor.py at roughly line 235:
```
def test_pyarrow_uuid_to_iceberg() -> None:
pyarrow_type = pa.uuid()
converted_iceberg_type = visit_pyarrow(pyarrow_type, _ConvertToIceberg())
assert converted_iceberg_type == UUIDType()
assert visit(converted_iceberg_type, _ConvertToArrowSchema()) ==
pa.uuid()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
