Guosmilesmile commented on code in PR #12979:
URL: https://github.com/apache/iceberg/pull/12979#discussion_r2107407568
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java:
##########
@@ -216,7 +235,44 @@ public SimpleVersionedSerializer<IcebergCommittable>
getCommittableSerializer()
@Override
public void addPostCommitTopology(
DataStream<CommittableMessage<IcebergCommittable>> committables) {
- // TODO Support small file compaction
+
+ if (!compactMode) {
+ return;
+ }
+
+ SingleOutputStreamOperator<TableChange> tableChangeStream =
+ committables
+ .global()
+ .process(new
CommittableToTableChangeConverter(tableLoader.clone()))
+ .uid("committable-to-table-change-converter")
Review Comment:
Good suggestion! I have done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
