liurenjie1024 commented on PR #1231: URL: https://github.com/apache/iceberg-rust/pull/1231#issuecomment-2909044061
> Are we sure that we need the CatalogBuilder trait? What would be its purpose? Hi, @c-thiel Sorry for misclarification. For more background, please refer to https://github.com/apache/iceberg-rust/issues/1228. In short, we are trying to develop a catalog loader so that it can be used by some applications such as iceberg-playground or data driven integration test framework. > My initial idea would be to just have different typesafe builders for different catalogs. The current CatalogBuilder trait currently contains fields that are not required for some catalogs. For example in-memory or dynamo don't even need a uri. I've refined the trait definition as proposed by @Xuanwo in #1372 . > On the other hand we have the rest catalog that needs [significantly more configurations](https://py.iceberg.apache.org/configuration/#rest-catalog), and I don't think we want to make those key value pairs. I would be in favor to have the interfaces as typesafe as possible. I think a pure type safe approach may not be practical since we also need to pass file io's configurations through catalog, and the actual file io used is determined at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
