BugenZhao commented on PR #1340: URL: https://github.com/apache/iceberg-rust/pull/1340#issuecomment-2908954714
Just to be clear: I'm also not introducing any sort of auto detection of feature here. It's totally opt-in, which is suggested according to your reference: > Crates should never automatically enable nightly features, this should generally be opt-in. Also there are some discussions at https://users.rust-lang.org/t/is-it-suitable-to-require-nightly-in-public-crate/97768: > In that case maybe you could make the nightly features opt-in, by hiding them behind a feature gate in your crate. I.e. a feature `nightly` which users can enable if they want to use the macro that is more elegant. > The standard practice is to use a [cargo feature](https://doc.rust-lang.org/cargo/reference/features.html) which you ask nightly users to enable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
