ggershinsky commented on code in PR #13066:
URL: https://github.com/apache/iceberg/pull/13066#discussion_r2103835988
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -124,13 +184,37 @@ protected void doRefresh() {
throw new RuntimeException("Interrupted during refresh", e);
}
+ if (encryptionKeyIdFromHMS != null) {
+ encryptionKeyId = encryptionKeyIdFromHMS; // todo gg
+ encryptionDekLength =
+ (dekLengthFromHMS != null)
+ ? Integer.parseInt(dekLengthFromHMS)
+ : TableProperties.ENCRYPTION_DEK_LENGTH_DEFAULT; // todo gg
+ }
+
refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries);
+
+ if (encryptionKeyIdFromHMS != null) {
+ checkEncryptionProperties(encryptionKeyIdFromHMS, dekLengthFromHMS);
+ encryptedKeysFromMetadata = current().encryptionKeys();
+ }
}
@SuppressWarnings({"checkstyle:CyclomaticComplexity", "MethodLength"})
@Override
protected void doCommit(TableMetadata base, TableMetadata metadata) {
boolean newTable = base == null;
+ encryptionPropsFromMetadata(metadata.properties());
+
+ if (encryption() instanceof StandardEncryptionManager) {
+ TableMetadata.Builder builder = TableMetadata.buildFrom(metadata);
+ for (Map.Entry<String, EncryptedKey> entry :
+ EncryptionUtil.encryptionKeys(encryption()).entrySet()) {
Review Comment:
yep, this PR is still not functional - it depends on #7770 , and also misses
a few parts. Once the 7770 is merged, I'll update this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
