Guosmilesmile commented on code in PR #12979: URL: https://github.com/apache/iceberg/pull/12979#discussion_r2102674112
########## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/RewriteDataFilesConfig.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.api; + +import java.util.Map; +import org.apache.iceberg.actions.RewriteDataFiles; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.PropertyUtil; + +public class RewriteDataFilesConfig { + public static final String CONFIG_PREFIX = "flink-maintenance.rewrite."; + + private final Map<String, String> properties; + + public RewriteDataFilesConfig(Map<String, String> newProperties) { + this.properties = Maps.newHashMap(); + newProperties.forEach( + (key, value) -> { + if (key.startsWith(CONFIG_PREFIX)) { + properties.put(key.substring(CONFIG_PREFIX.length()), value); + } + }); + } + + public static final String PARTIAL_PROGRESS_ENABLE = + org.apache.iceberg.actions.RewriteDataFiles.PARTIAL_PROGRESS_ENABLED; + + public static final String PARTIAL_PROGRESS_MAX_COMMITS = + org.apache.iceberg.actions.RewriteDataFiles.PARTIAL_PROGRESS_MAX_COMMITS; + + public static final String MAX_BYTES = "max-bytes"; + + public static final String SCHEDULE_ON_COMMIT_COUNT = "schedule.commit-count"; + public static final int SCHEDULE_ON_COMMIT_COUNT_DEFAULT = 10; + + public static final String SCHEDULE_ON_DATA_FILE_COUNT = "schedule.data-file-count"; + public static final int SCHEDULE_ON_DATA_FILE_COUNT_DEFAULT = 1000; + + public static final String SCHEDULE_ON_DATA_FILE_SIZE = "schedule.data-file-size"; + public static final long SCHEDULE_ON_DATA_FILE_SIZE_DEFAULT = 100L * 1024 * 1024 * 1024; // 100G + + public static final String SCHEDULE_ON_INTERVAL_SECOND = "schedule.interval-second"; + public static final int SCHEDULE_ON_INTERVAL_SECOND_DEFAULT = 10 * 60; // 10 minutes + + public int scheduleOnCommitCount() { + return PropertyUtil.propertyAsInt( Review Comment: https://github.com/apache/iceberg/blob/743d6f4574dfbbc9b78f4777c3aec2714777bcb8/flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java#L601-L609 When we create the compaction properties , we handle the overrides hints/job level configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
