kevinjqliu commented on code in PR #1367:
URL: https://github.com/apache/iceberg-rust/pull/1367#discussion_r2102720796
##########
scripts/release.sh:
##########
@@ -32,6 +32,12 @@ rc_version="${ICEBERG_VERSION_RC:-rc.1}"
# Corresponding git repository branch
git_branch=release-${release_version}-${rc_version}
+echo "> Check license"
+docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header
check
Review Comment:
yep! i just double checked.
Previously the script `cd` into `dist` and then back to parent before
running the license check.
Now it runs the license check in the parent directory before cd'ing into
`dist`
In both cases, the license check runs on repo's root dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
