nastra commented on code in PR #13118:
URL: https://github.com/apache/iceberg/pull/13118#discussion_r2101826034
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -453,7 +453,7 @@ public void initialize(Map<String, String> props) {
// Do not override s3 client if it was provided
if (s3 == null) {
- Object clientFactory = S3FileIOAwsClientFactories.initialize(props);
+ Object clientFactory =
S3FileIOAwsClientFactories.initialize(propertiesWithCredentials);
Review Comment:
FYI this is going to be fixed by
https://github.com/apache/iceberg/pull/12799 but it's still good to get the
tests in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
