kevinjqliu commented on PR #1363:
URL: https://github.com/apache/iceberg-rust/pull/1363#issuecomment-2899812922

   Thanks @Fokko! Looking at the script, I realized that the directories to 
check are hardcoded 
   
https://github.com/apache/iceberg-rust/blob/aa24cf4ef724104dba589b88731b5d36e2295acb/scripts/dependencies.py#L23-L33
   
   In the project, there are a few other directories with `Cargo.toml` that's 
not in the list above. For example,
   ```
   crates/catalog/s3tables
   crates/integrations/cache-moka
   crates/integrations/cli
   crates/examples
   crates/integration_tests
   crates/sqllogictest
   crates/test_utils
   ```
   
   These are generated using `find . -name Cargo.toml -exec dirname {} \; `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to