dhruv-pratap commented on code in PR #13108:
URL: https://github.com/apache/iceberg/pull/13108#discussion_r2100539842
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetReader.java:
##########
@@ -120,18 +125,27 @@ public boolean hasNext() {
@Override
public T next() {
- if (valuesRead >= nextRowGroupStart) {
- advance();
- }
-
- if (reuseContainers) {
- this.last = model.read(last);
- } else {
- this.last = model.read(null);
+ try {
+ if (valuesRead >= nextRowGroupStart) {
+ advance();
+ }
+
+ if (reuseContainers) {
+ this.last = model.read(last);
+ } else {
+ this.last = model.read(null);
+ }
+ valuesRead += 1;
+
+ return last;
+ } catch (ParquetDecodingException e) {
+ if (reader != null) {
Review Comment:
It does seem plausible since `org.apache.parquet.hadoop.ParquetFileReader`,
from where the value of `reader` is being inherited in `ParquetReader`, has
nullable checks for `reader` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
